-
Notifications
You must be signed in to change notification settings - Fork 903
Update to gradle v9 #7590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to gradle v9 #7590
Conversation
- Update gradle wrapper to 9.0.0 - Fix gradle configuration issues in build files - Remove redundant configuration.add() calls in animal-sniffer-signature - Update protobuf gradle plugin dependency - Fix ProjectDependency comparison in custom-checks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7590 +/- ##
============================================
- Coverage 90.01% 89.99% -0.02%
+ Complexity 7080 7079 -1
============================================
Files 803 803
Lines 21417 21419 +2
Branches 2086 2086
============================================
- Hits 19278 19276 -2
- Misses 1477 1479 +2
- Partials 662 664 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Co-authored-by: Trask Stalnaker <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing! Thanks @jaydeluca. Curious if you tried any of the publish work (like even ./gradlew publishToMavenLocal
)?
@breedx-splk yes publishToMavenLocal looks good for me locally, are there others I would be able to test that you think would be useful? |
Not off the top of my head -- just thinking about potential edge cases that don't get flexed in the normal PR and main merge builds. Thanks again! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Supersedes #7523